Skip to content

fix: escape invalid id's to prevent WSOD #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2020
Merged

fix: escape invalid id's to prevent WSOD #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/lib/queryAdvise.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,12 @@ export function getData({ root, element }) {
const type = element.getAttribute('type');
const tagName = element.tagName;

// prevent querySelector from tripping over corrupted html like <input id="button\n<button>
const id = (element.getAttribute('id') || '').split('\n')[0];
// escape id to prevent querySelector from tripping over corrupted html like:
// <input id="button\n<button> & <input id=\ntype="text" />
const id = (element.getAttribute('id') || '')
.replace(/\s/g, '')
.replace(/"/g, '\\"');

const labelElem = id ? root.querySelector(`[for="${id}"]`) : null;
const labelText = labelElem ? labelElem.innerText : null;

Expand Down