-
-
Notifications
You must be signed in to change notification settings - Fork 72
feat: add support for user-event
#209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
user-eventsuser-event
9b84bd7 to
7cda2cd
Compare
9b2a239 to
d2c2c91
Compare
|
Ok, I don't have much time this week. So I'm going to merge this tomorrow unless there are blocking issues that I've missed. I still want the menu in a different position in the tree, and I should have cleaned up the parser. But that can be done in a new PR once there is time. If anyone is reading this before I have pushed the merge button, and feeling to test/review, please take a shot. It would be much appreciated. |
|
@delca85 , it looks like there are two CodeMirror instances bound to the same element. Do you remember which steps you took to trigger that problem? A reproduction would be very helpful. |
|
I am not able to reproduce this behavior right now.
|


What:
I've done a number of things in the PR.
Sandboxed the preview pane
Communication with the top frame is handled through the
postMessageAPI.Highlighting
Parser
@testing-library/user-eventshas been added to the evaluator context. User events are available underuseranduserEvent.Query Pane
The query pane now has two menu buttons:
runThe run button enables the user to execute queries manually. It's also possible to trigger this action with
cmd + enterorctrl + enter. While a query is being evaluated, aloaderis rendered instead.auto syncThis button enables/disables automatic synchronization. It also allows the user to toggle between the pre/post query state in the preview pane. Some users might find the automatic evaluation confusing when working with user-events. This button might offer some help.
Result Pane
Previewpane when there is no queryGeneric
@primer/octicons-reactDevtools
runandsyncbutton.Why:
Because it's awesome!
How:
Check the code and "What" above. It's a lot!
Checklist:
resolves #10
resolves #69
todo
parsingindicators