-
-
Couldn't load subscription status.
- Fork 72
feat: add sorter for DomEvents #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
smeijer
merged 12 commits into
testing-library:develop
from
marcosvega91:pr/fix_mode_as_dep
Jun 26, 2020
Merged
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
5cafdc0
fix: add mode as dep
marcosvega91 660e524
chore: add react-hooks-testing-library dep
marcosvega91 aebdc43
feat: add sorter function for table
marcosvega91 6ff070a
fix: fix check on dep
marcosvega91 24d98ce
fix: initial sorting on asc
marcosvega91 a3e390e
refactor: use typeerror instead of error
marcosvega91 9c2c419
chore: remove old hook testing library
marcosvega91 5379dce
fix: sort only by id
marcosvega91 73dbc2f
Merge branch 'develop' into pr/fix_mode_as_dep
marcosvega91 7d0345c
fix: linter
marcosvega91 a38b616
fix: remove old params
marcosvega91 0b36663
Merge branch 'develop' into pr/195
smeijer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| import React from 'react'; | ||
|
|
||
| function defaultSorter(data, sortBy, direction) { | ||
| return [...data].sort((row1, row2) => { | ||
| const sortInt = `${row1[sortBy]}`.localeCompare( | ||
| `${row2[sortBy]}`, | ||
| undefined, | ||
| { numeric: true }, | ||
| ); | ||
| return direction === 'desc' ? -sortInt : sortInt; | ||
| }); | ||
| } | ||
|
|
||
| function useSorter({ | ||
| rows = [], | ||
| sortBy, | ||
| sortDirection = 'desc', | ||
| sortByFn = defaultSorter, | ||
| }) { | ||
| if (!Array.isArray(rows)) { | ||
| throw TypeError('rows should be an array'); | ||
| } | ||
|
|
||
| if (sortDirection !== 'desc' && sortDirection !== 'asc') { | ||
| throw Error('sort direction can be desc or asc'); | ||
| } | ||
|
|
||
| const sortedRows = React.useMemo(() => { | ||
| const sortedRows = sortByFn(rows, sortBy, sortDirection); | ||
| return sortedRows; | ||
| }, [JSON.stringify(rows), sortBy, sortByFn, sortDirection]); | ||
|
|
||
| return [sortedRows, rows]; | ||
| } | ||
|
|
||
| export default useSorter; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.