Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run vitest on jsdom and happy-dom #297

Merged
merged 1 commit into from
Jan 31, 2024
Merged

ci: run vitest on jsdom and happy-dom #297

merged 1 commit into from
Jan 31, 2024

Conversation

mcous
Copy link
Collaborator

@mcous mcous commented Jan 27, 2024

Overview

This is the third PR in a series to add multiple Svelte versions and test runners to our CI test matrix.

  1. feat(vitest): add vitest cleanup export #294
  2. ci: test against svelte v3 and v4 #295
  3. ci: run vitest on jsdom and happy-dom #297 <-- you are here
  4. TODO add Jest to CI matrix

This PR supersedes or unblocks #286, depending on what we want our default DOM environment to be for local development

Change log

  • Add scripts to explicitly test using Vitest + jsdom and Vitest + happy-dom
  • Hook those scripts up to the CI matrix

Review requests

How does a CI matrix feel vs running runners on one VM? The matrix keeps the Vitest config simpler, because we don't need to do stuff like isolate the coverage directories, but it uses more "computers" to do so

@mcous mcous marked this pull request as ready for review January 29, 2024 22:29
@yanick yanick merged commit c8158a9 into testing-library:main Jan 31, 2024
14 checks passed
@mcous mcous deleted the ci-multiple-env branch February 1, 2024 05:47
Copy link

🎉 This PR is included in version 4.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants