Skip to content

Conversation

@nickserv
Copy link
Member

@nickserv nickserv commented Nov 14, 2020

Generated with yo kcd-oss

See testing-library/dom-testing-library#809 for rationale and history

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 14, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ffe456a:

Sandbox Source
React Configuration
react-testing-library-examples Configuration

@nickserv nickserv marked this pull request as ready for review November 14, 2020 08:37
@nickserv
Copy link
Member Author

Any ideas why this isn't running on GitHub Actions but testing-library/dom-testing-library#809 was? I was hoping to test this before merging it.

@nickserv nickserv requested a review from kentcdodds November 14, 2020 08:40
@MatanBobi
Copy link
Member

MatanBobi commented Nov 14, 2020

Any ideas why this isn't running on GitHub Actions but testing-library/dom-testing-library#809 was? I was hoping to test this before merging it.

I think that the workflows folder should be under the .github folder so you probably missed the . here, I think it will fix that :)

@nickserv
Copy link
Member Author

nickserv commented Nov 14, 2020

Uh oh... I think that needs to be fixed upstream in generator-kcd-oss

@nickserv
Copy link
Member Author

TypeScript ESLint issues are failing the build

@MatanBobi
Copy link
Member

TypeScript ESLint issues are failing the build

Looks like this is because of the kcd-scripts version that needs to be upgraded like @kentcdodds did here :)

@nickserv
Copy link
Member Author

I keep getting this error after upgrading it, adding a tsconfig.json does not help:

[lint] Error: Error while loading rule '@typescript-eslint/no-unsafe-assignment': You have used a rule which requires parserServices to be generated. You must therefore provide a value for the "parserOptions.project" property for @typescript-eslint/parser.

@kentcdodds
Copy link
Member

I'm working on fixing this now

@kentcdodds
Copy link
Member

Alrighty, now eslint-config-kentcdodds will automatically find the tsconfig.json and set that as the project. This passes locally so we should be good here as well.

@codecov
Copy link

codecov bot commented Nov 14, 2020

Codecov Report

Merging #826 (ffe456a) into master (007b0b7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #826   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          117       140   +23     
  Branches        16        28   +12     
=========================================
+ Hits           117       140   +23     
Impacted Files Coverage Δ
src/pure.js 100.00% <0.00%> (ø)
src/act-compat.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 007b0b7...ffe456a. Read the comment docs.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super duper! Thanks 👏

@kentcdodds kentcdodds merged commit 3af1b4b into master Nov 14, 2020
@kentcdodds kentcdodds deleted the pr/use-actions-instead branch November 14, 2020 16:19
@github-actions
Copy link

🎉 This PR is included in version 11.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants