Skip to content

feat: Move @testing-library/dom and @types/react-dom to peer dependencies #1305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 3, 2024
Merged

feat: Move @testing-library/dom and @types/react-dom to peer dependencies #1305

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9e34b45
feat: Move `@types/react-dom` to peer dependencies
eps1lon Apr 22, 2024
c4b764e
feat!: move dtl to peerDeps
eps1lon Apr 26, 2024
d91d665
Merge branch 'main' into peer-types
MatanBobi Jun 1, 2024
7bb03cc
push @types/react-dom back
MatanBobi Jun 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into peer-types
  • Loading branch information
@MatanBobi
MatanBobi committed Jun 1, 2024
commit d91d6650901c152ed5e27e17f290ca8020b7ae77
6 changes: 5 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"devDependencies": {
"@testing-library/dom": "^10.0.0",
"@testing-library/jest-dom": "^5.11.6",
"@types/react-dom": "^18.2.25",
"@types/react": "^18.3.1",
"chalk": "^4.1.2",
"dotenv-cli": "^4.0.0",
"jest-diff": "^29.7.0",
Expand All @@ -64,10 +64,14 @@
"peerDependencies": {
"@testing-library/dom": "^10.0.0",
"@types/react-dom": "^18.0.0",
"@types/react": "^18.0.0",
"react": "^18.0.0",
"react-dom": "^18.0.0"
},
"peerDependenciesMeta": {
"@types/react": {
"optional": true
},
"@types/react-dom": {
"optional": true
}
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.