-
Notifications
You must be signed in to change notification settings - Fork 232
Global cleanup #199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Global cleanup #199
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
183c3ce
Added cleanup and autocleanup functionality
mpeyper ba02be0
Documented the cleanup and auto-cleanup functionality
mpeyper 73c1f61
Moved cleanup logic into seperate file
mpeyper 217e299
Moved cleanup definition in logs to match other API references
mpeyper File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Documented the cleanup and auto-cleanup functionality
- Loading branch information
commit ba02be0caa2cd8241a8597484998b19f341df887
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ Do you happen to have any reference or example of a testing library auto adding a global
afterEach
?I think I like this, i'm just curious about community best practices and such.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The registration of this is lifted almost verbatim from
@testing-library/react-testing-library#430
I don't think this is a commonly used pattern (yet).