Skip to content

feat: update @library-testing/dom to 7 #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2020
Merged

feat: update @library-testing/dom to 7 #30

merged 1 commit into from
Mar 21, 2020

Conversation

abraham
Copy link
Contributor

@abraham abraham commented Mar 13, 2020 •
edited
Loading

  • Update @testing-library/dom to v7
  • Update wait-for-expect to v3
  • Install matching @types/puppeteer version on CI
  • Update pptr version matrix
  • Updated dom-testing-library references in readme
  • Attempted to replace waitForException with @testing-library/dom's wait but it requires dom access
  • [@testing-library/dom] update to v7 DefinitelyTyped/DefinitelyTyped#43102 is taking a while to merge so I removed waitFor untill the types are updated.

@abraham abraham marked this pull request as ready for review March 20, 2020 20:47
patrickhulce
patrickhulce reviewed Mar 21, 2020
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @abraham! LGTM otherwise :)

@patrickhulce patrickhulce merged commit 67106ba into testing-library:master Mar 21, 2020
@abraham abraham deleted the dtl-7 branch March 21, 2020 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abraham @patrickhulce