feat: support changes for native-testing-library preset #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next #2 +/- ##
===================================
Coverage 100% 100%
===================================
Files 8 8
Lines 89 89
Branches 23 23
===================================
Hits 89 89
Continue to review full report at Codecov.
|
bcarroll22
changed the title
bcarroll22
force-pushed
the
pr/jest-preset
branch
from
2f2bd4c
to
2813c82
Compare
bcarroll22
force-pushed
the
pr/jest-preset
branch
from
2813c82
to
1e36898
Compare
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
A jest preset meant to supercharge
native-testing-libraryWhy:
I want the same "DOM" feel in
debugoutput and snapshots asdom-testing-librarygives you. I think the RN core team already has a good idea of the type of mocks they want in the bundled jest preset, so for now we'll create our own to emulate the feel we want.Ultimately, I could totally see these mocks merging back into
react-native, and I hope it does but until then, I'd like to be able to use this functionality as soon as possible. If for no other reason than the delay of merged features in RN, I think this is necessary to get moving,How:
This requires unmocking some things from the
react-nativepreset and doing it ourself.Checklist: