Skip to content

chore: add tests for Node 16 #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2021
Merged

Conversation

MichaelDeBoey
Copy link
Member

@MichaelDeBoey MichaelDeBoey commented Apr 21, 2021

@codecov
Copy link

codecov bot commented Apr 21, 2021

Codecov Report

Merging #357 (b525f21) into main (21ad89b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #357   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines          545       545           
  Branches       200       198    -2     
=========================================
  Hits           545       545           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21ad89b...b525f21. Read the comment docs.

@gnapse
Copy link
Member

gnapse commented Apr 21, 2021

I wonder why there's a check entry above that has not reported its status. I need to investigate before merging. Any hints that you can give?

@MichaelDeBoey
Copy link
Member Author

MichaelDeBoey commented Apr 21, 2021

@gnapse I think you need to update branch protection rules (in settings of this repo) like @eps1lon did after testing-library/react-testing-library#900

@gnapse gnapse merged commit 7d1c742 into testing-library:main Apr 22, 2021
@github-actions
Copy link

🎉 This PR is included in version 5.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MichaelDeBoey MichaelDeBoey deleted the patch-1 branch April 22, 2021 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants