-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove snapshots #16
Remove snapshots #16
Conversation
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
=======================================
Coverage ? 100%
=======================================
Files ? 8
Lines ? 74
Branches ? 15
=======================================
Hits ? 74
Misses ? 0
Partials ? 0 Continue to review full report at Codecov.
|
You could also strip the ansi characters with a snapshot serializer. I'm pretty sure there's a module that does this. |
Also disable chalk before tests |
There's a just issue I referenced in the PR that introduced this problem (jestjs/jest#4407) where they talk a bit more about this, and that it is expected. They suggest the serializer there, but I haven't found any yet. Suggestions of where to look are welcome. I already looked in jest-awesome with no luck. I also should've detected this in the original PR, because the codecov report never appeared and I did not notice. BTW, interesting the |
Try this one: https://github.com/joaogranado/jest-serializer-ansi |
Done in #17, but somehow build is still failing over there, even when they all pass locally :( |
Ugh. |
Most likely that's the issue travis-ci/travis-ci#7967 |
There doesn't seem to be a definite solution for this problem in that travis issue discussion :( Given that #17 remains failing for some other reason even after serializing snapshots without the ansi stuff, I'm leaning towards merging this PR, because it nevertheless fixes the issue reported in testing-library/dom-testing-library#50. I'll try to dig a bit more and wait until later today, to see if a this can be solved. Otherwise I'll merge this PR because we can always bring back the snapshots with proper serialization and/or travis settings fixed or whatever, in a later PR. |
🎉 This PR is included in version 1.3.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
What:
Removing snapshots of error messages in the tests that are expected to throw.
Why:
Because the terminal output stored I these snapshots is not the same in terminals where colors are not supported, such as in Travis-CI.
Checklist: