-
Notifications
You must be signed in to change notification settings - Fork 150
fix: replace use of deprecated methods #925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
5c83d70
fix: introduce utilities for v9 compatability
G-Rath 15e4f44
fix: replace uses of `context.getFilename`
G-Rath 142bb23
fix: replace uses of `context.getSourceCode`
G-Rath 4944903
fix: replace uses of `context.getScope`
G-Rath 8cc3676
fix: replace uses of `context.getDeclaredVariables`
G-Rath 83538d3
refactor: remove unneeded compat utility
G-Rath 1070572
refactor: apply prettier
G-Rath 88ecc28
chore: adjust eslint inline disables
G-Rath File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,80 @@ | ||
import { type TSESLint, type TSESTree } from '@typescript-eslint/utils'; | ||
|
||
declare module '@typescript-eslint/utils/dist/ts-eslint/Rule' { | ||
export interface RuleContext< | ||
// eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
TMessageIds extends string, | ||
// eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
TOptions extends readonly unknown[], | ||
> { | ||
/** | ||
* The filename associated with the source. | ||
*/ | ||
filename: string; | ||
|
||
/** | ||
* A SourceCode object that you can use to work with the source that | ||
* was passed to ESLint. | ||
*/ | ||
sourceCode: Readonly<TSESLint.SourceCode>; | ||
} | ||
} | ||
|
||
declare module '@typescript-eslint/utils/dist/ts-eslint/SourceCode' { | ||
export interface SourceCode { | ||
/** | ||
* Returns the scope of the given node. | ||
* This information can be used track references to variables. | ||
* @since 8.37.0 | ||
*/ | ||
getScope(node: TSESTree.Node): TSESLint.Scope.Scope; | ||
/** | ||
* Returns an array of the ancestors of the given node, starting at | ||
* the root of the AST and continuing through the direct parent of the current node. | ||
* This array does not include the currently-traversed node itself. | ||
* @since 8.38.0 | ||
*/ | ||
getAncestors(node: TSESTree.Node): TSESTree.Node[]; | ||
/** | ||
* Returns a list of variables declared by the given node. | ||
* This information can be used to track references to variables. | ||
* @since 8.38.0 | ||
*/ | ||
getDeclaredVariables( | ||
node: TSESTree.Node | ||
): readonly TSESLint.Scope.Variable[]; | ||
} | ||
} | ||
|
||
/* istanbul ignore next */ | ||
export const getFilename = ( | ||
context: TSESLint.RuleContext<string, unknown[]> | ||
) => { | ||
return context.filename ?? context.getFilename(); | ||
}; | ||
|
||
/* istanbul ignore next */ | ||
export const getSourceCode = ( | ||
context: TSESLint.RuleContext<string, unknown[]> | ||
) => { | ||
return context.sourceCode ?? context.getSourceCode(); | ||
}; | ||
|
||
/* istanbul ignore next */ | ||
export const getScope = ( | ||
context: TSESLint.RuleContext<string, unknown[]>, | ||
node: TSESTree.Node | ||
) => { | ||
return getSourceCode(context).getScope?.(node) ?? context.getScope(); | ||
}; | ||
|
||
/* istanbul ignore next */ | ||
export const getDeclaredVariables = ( | ||
context: TSESLint.RuleContext<string, unknown[]>, | ||
node: TSESTree.Node | ||
) => { | ||
return ( | ||
getSourceCode(context).getDeclaredVariables?.(node) ?? | ||
context.getDeclaredVariables(node) | ||
); | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
export * from './compat'; | ||
export * from './file-import'; | ||
export * from './types'; | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.