Skip to content

Move rules settings to ESLint shared config: refactor no-wait-for-multiple-assertions rule #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Mar 27, 2021
Merged

Move rules settings to ESLint shared config: refactor no-wait-for-multiple-assertions rule #301

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
56bbeae
test: improve errors location asserts
Belco90 Mar 24, 2021
98d5868
refactor: use new rule creator
Belco90 Mar 24, 2021
56d5dd4
refactor: improve error reported location
Belco90 Mar 24, 2021
dd333e5
refactor: use new helpers for detection
Belco90 Mar 24, 2021
4cbd073
test: add more cases
Belco90 Mar 25, 2021
d549af7
feat: detect properly if fireEvent and userEvent should be reported
Belco90 Mar 25, 2021
ed9fe56
test: add cases for increasing coverage up to 100%
Belco90 Mar 25, 2021
a2e7d2d
refactor: rename rule for consistency
Belco90 Mar 25, 2021
d740d03
docs: remove duplicated no-wait-for-snapshot row
Belco90 Mar 25, 2021
6fad676
refactor: rename rule
Belco90 Mar 26, 2021
af5375e
test: improve errors location asserts
Belco90 Mar 26, 2021
f7f348d
refactor: use new rule creator
Belco90 Mar 26, 2021
61b131c
refactor: use new helpers for detection
Belco90 Mar 26, 2021
ccee1a6
refactor: improve error reported location
Belco90 Mar 26, 2021
c8784ba
test: add more cases
Belco90 Mar 26, 2021
c110177
Merge remote-tracking branch 'origin/v4' into 198/no-wait-for-multipl…
Belco90 Mar 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: use new rule creator
  • Loading branch information
@Belco90
Belco90 committed Mar 26, 2021
commit f7f348da3dc8893202024b9cd22dabf705ec7efa
12 changes: 4 additions & 8 deletions lib/rules/no-wait-for-multiple-assertions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,18 @@
import {
ESLintUtils,
TSESTree,
ASTUtils,
} from '@typescript-eslint/experimental-utils';
import { getDocsUrl } from '../utils';
import { ASTUtils, TSESTree } from '@typescript-eslint/experimental-utils';
import {
isBlockStatement,
isMemberExpression,
isCallExpression,
isMemberExpression,
} from '../node-utils';
import { createTestingLibraryRule } from '../create-testing-library-rule';

export const RULE_NAME = 'no-wait-for-multiple-assertions';
export type MessageIds = 'noWaitForMultipleAssertion';
type Options = [];

const WAIT_EXPRESSION_QUERY = 'CallExpression[callee.name=/^(waitFor)$/]';

export default ESLintUtils.RuleCreator(getDocsUrl)<Options, MessageIds>({
export default createTestingLibraryRule<Options, MessageIds>({
name: RULE_NAME,
meta: {
type: 'suggestion',
Expand Down