fix(suggestions): only warn about inaccessible elements when actually showing the suggestion #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… showing the suggestion
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit dd60cdd:
|
Codecov Report
@@ Coverage Diff @@
## master #827 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 922 923 +1
Branches 281 282 +1
=========================================
+ Hits 922 923 +1
Continue to review full report at Codecov.
|
marcosvega91
approved these changes
Nov 18, 2020
|
🎉 This PR is included in version 7.27.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Console warnings are being emitted, even when they shouldn't be. For example, if you're using getByRole, you shouldn't see a warning about it, only when the suggestion is actually used.
Why:
causes noise in test runs.
How:
by moving the console.warn into the toString() which is only used when the suggestion is thrown.
Checklist:
docs site N/A