-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for firing all transition events #1036
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a689fb0:
|
8325d33
to
4e8df21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR is missing the changes from running npm run format
.
Make sure that npm run validate
passes locally.
Sorry for the bad start, I knew I shouldn't have opened the PR yesterday as it was too late for me. I have properly formatted the code now.
It should pass on CI as the test seems unrelated to this change. |
There's nothing to appologize for. I just left the review so that you're notified of the CI failure since GitHub blocks CI for 1st time contributors.
Yeah, we're not sure why these are failing for some people (myself included) locally but pass CI. |
Codecov Report
@@ Coverage Diff @@
## main #1036 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 25 25
Lines 920 920
Branches 286 284 -2
=========================================
Hits 920 920
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
🎉 This PR is included in version 8.6.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
@eps1lon about these two tests that are failing locally, if we remove the highlighting then they pass, not sure if you have noticed this. const codeFrame = codeFrameColumns(
rawFileContents,
{
start: {line, column},
},
{
highlightCode: false, // no highlight
linesBelow: 0,
},
)
return `${frameLocation}\n${codeFrame}\n` // no dim
} This seems very suspicious: |
Thanks for looking into it! Could you open an issue so that we can track it better? Closed PRs are usually not watched |
What:
Add support for firing all transition events.
Why:
Currently only
transitionEnd
even is supported.How:
Defining all other events,
transitionCancel
,transitionRun
,transitionStart
.Checklist: