Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

querying aria-role superclass hierarchies #448

Closed
alexkrolick opened this issue Feb 4, 2020 · 6 comments
Closed

querying aria-role superclass hierarchies #448

alexkrolick opened this issue Feb 4, 2020 · 6 comments
Assignees
@delca85
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@alexkrolick
Copy link
Collaborator

alexkrolick commented Feb 4, 2020 •
edited
Loading

getByRole should be able to understand superclass hierarchies such as:

input      [abstract, debatable whether this should be queryable?]
  checkbox
    switch   (should be able to get switch by switch, checkbox, or input)
  option
  radio
  slider
  spinbutton
  textbox

Looks related to #446

Examples: https://codesandbox.io/s/young-tree-68kbl
@kentcdodds
Copy link
Member

Not sure whether to label this as a bug or enhancement, but either way, this would be great :)

@kentcdodds kentcdodds added the help wanted Extra attention is needed label Mar 3, 2020
@kentcdodds
Copy link
Member

Actually, I feel like this should be something that aria-query or dom-accessibility-api should handle 🤔

It's definitely an enhancement though :)

@kentcdodds kentcdodds added the enhancement New feature or request label Mar 4, 2020
@alexkrolick
Copy link
Collaborator Author

Sounds like aria-query provides this functionality

@eps1lon eps1lon mentioned this issue May 12, 2020
Closed
@delca85
Copy link
Member

delca85 commented Jun 25, 2020

If it sounds good to all of you, I could try to make this enhancement!

@kentcdodds
Copy link
Member

That sounds great to me @delca85!

delca85 pushed a commit to delca85/dom-testing-library that referenced this issue Jun 27, 2020
add role-helpers function to retrieve superclass from role (testing-l…
2b34806 
…ibrary#448)
delca85 pushed a commit to delca85/dom-testing-library that referenced this issue Jun 27, 2020
match even superclass roles in queryAllByRole (testing-library#448)
5f9b024
delca85 pushed a commit to delca85/dom-testing-library that referenced this issue Jun 27, 2020
fix tests according to superclass roles matching (testing-library#448)
bd1c6d9
@delca85 delca85 mentioned this issue Jun 27, 2020
Closed
7 tasks
@nickserv nickserv mentioned this issue Jul 7, 2020
Merged
@kentcdodds
Copy link
Member

We've decided to not implement this.

@alexkrolick alexkrolick mentioned this issue Dec 4, 2020
Open
@timdeschryver timdeschryver mentioned this issue Dec 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@delca85 delca85

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kentcdodds @alexkrolick @delca85