Options type missing in prettyDOM function

[thomaslombart]

Problem description:

The options type of the prettyDOM function is missing in the typings.

Suggested solution:

Add the following types in typings/pretty-dom.d.ts

import {Options} from 'pretty-format'

export function prettyDOM(
  element: HTMLElement,
  maxLength?: number,
  options?: Options,
): string | false

[thomaslombart]

I actually tried to add the missing types as described in the suggested solution and open a PR but I got a weird error during the pre-commit:

I also got few errors while running dtslint:

Error: Errors in typescript@2.8 for external dependencies:
../node_modules/@babel/parser/typings/babel-parser.d.ts(11,64): error TS2304: Cannot find name 'import'.
../node_modules/@babel/parser/typings/babel-parser.d.ts(11,70): error TS1144: '{' or ';' expected.
../node_modules/@babel/parser/typings/babel-parser.d.ts(11,87): error TS2339: Property 'File' does not exist on type '"@babel/types"'.
../node_modules/@babel/parser/typings/babel-parser.d.ts(16,74): error TS2304: Cannot find name 'import'.
../node_modules/@babel/parser/typings/babel-parser.d.ts(16,80): error TS1144: '{' or ';' expected.
../node_modules/@babel/parser/typings/babel-parser.d.ts(16,97): error TS2339: Property 'Expression' does not exist on type '"@babel/types"'.
../node_modules/@types/yargs/index.d.ts(99,106): error TS2304: Cannot find name 'unknown'.
../node_modules/@types/yargs/index.d.ts(106,112): error TS2304: Cannot find name 'unknown'.
../node_modules/@types/yargs/index.d.ts(267,28): error TS2304: Cannot find name 'unknown'.
../node_modules/@types/yargs/index.d.ts(403,9): error TS2304: Cannot find name 'unknown'.

I couldn't figure out where do the errors come from. Do you have any idea?

[kentcdodds]

I need to fix kcd-scripts to support TS files.

For now, go ahead and commit with --no-verify

[kentcdodds]

If you rebase your changes with master, you shouldn't have this problem anymore.

[kentcdodds]

Nevermind, this was already done in #309 😅

Thanks again!