Skip to content

feat: support ngOnChanges with correct simpleChange object within rerender #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 10, 2023
Merged

feat: support ngOnChanges with correct simpleChange object within rerender #366

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e4acbbd
feat: support ngOnChanges with correct simple change object within re…
shaman-apprentice Feb 11, 2023
66ba0c7
Update projects/testing-library/tests/rerender.spec.ts
shaman-apprentice Feb 21, 2023
4c5a255
feat: support detectChangesOnRender within rerender
shaman-apprentice Mar 5, 2023
d218907
feat: only check for own detectChangesOnRender flag
shaman-apprentice Mar 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
feat: only check for own detectChangesOnRender flag 
ref #365
  • Loading branch information
@shaman-apprentice
shaman-apprentice committed Mar 10, 2023
commit d2189079fdb1e3a1d7903d1d7872722fa66c3985
5 changes: 1 addition & 4 deletions projects/testing-library/src/lib/testing-library.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,10 +157,7 @@ export async function render<SutType, WrapperType = SutType>(
}
renderedPropKeys = Object.keys(newComponentProps);

if (
properties?.detectChangesOnRender === true ||
(properties?.detectChangesOnRender === undefined && detectChangesOnRender === true)
) {
if (properties?.detectChangesOnRender !== false) {
fixture.componentRef.injector.get(ChangeDetectorRef).detectChanges();
}
};
Expand Down
40 changes: 7 additions & 33 deletions projects/testing-library/tests/rerender.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,39 +82,13 @@ test('rerenders the component with updated props and resets other props', async
});
});

describe('detectChangesOnRender', () => {
test('change detection gets not called if disabled within render', async () => {
const { rerender, detectChanges } = await render(FixtureComponent, { detectChangesOnRender: false });
detectChanges();
expect(screen.getByText('Sarah')).toBeInTheDocument();

const firstName = 'Mark';
await rerender({ componentInputs: { firstName } });

expect(screen.getByText('Sarah')).toBeInTheDocument();
expect(screen.queryByText(firstName)).not.toBeInTheDocument();
});

test('change detection gets called if disabled within render but enabled within rerender', async () => {
const { rerender, detectChanges } = await render(FixtureComponent, { detectChangesOnRender: false });
detectChanges();
expect(screen.getByText('Sarah')).toBeInTheDocument();

const firstName = 'Mark';
await rerender({ componentInputs: { firstName }, detectChangesOnRender: true });

expect(screen.getByText(firstName)).toBeInTheDocument();
expect(screen.queryByText('Sarah')).not.toBeInTheDocument();
});

test('change detection gets not called if disabled within rerender', async () => {
const { rerender } = await render(FixtureComponent);
expect(screen.getByText('Sarah')).toBeInTheDocument();
test('change detection gets not called if `detectChangesOnRender` is set to false', async () => {
const { rerender } = await render(FixtureComponent);
expect(screen.getByText('Sarah')).toBeInTheDocument();

const firstName = 'Mark';
await rerender({ componentInputs: { firstName }, detectChangesOnRender: false });
const firstName = 'Mark';
await rerender({ componentInputs: { firstName }, detectChangesOnRender: false });

expect(screen.getByText('Sarah')).toBeInTheDocument();
expect(screen.queryByText(firstName)).not.toBeInTheDocument();
});
expect(screen.getByText('Sarah')).toBeInTheDocument();
expect(screen.queryByText(firstName)).not.toBeInTheDocument();
});