split install.sh script into multiple scripts #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is addressing testground/testground#1166 and testground/testground#1129
It is splitting the
install.shscript into multiple scripts, so that these playbooks accommodate both for adhoc Kubernetes deployments (those that we have been creating until now), as well as Testground as a Server / upgradeable environment - one where you would want to be able to upgrade the Kubernetes cluster, but keep EFS and EBS in tact.It is splitting the global
$NAMEvariable into$DEPLOYMENT_NAMEand$CLUSTER_NAME- the rational is that DEPLOYMENT encompasses EBS, EFS and the Kubernetes cluster, whereas CLUSTER_NAME refers only to the Kubernetes cluster. This way we can create a new cluster, and easily attach it to an existing EFS file system and EBS volume (obviously the cluster needs to be in the same AWS region).It is adding EBS playbooks - until now we were storing the Testground datadir on a volume on the host EC2 instance. Now we are using an EBS volume for that purpose.