-
Notifications
You must be signed in to change notification settings - Fork 4
feat: add optional --older-than flag #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add optional --older-than flag #18
Conversation
|
Hey @Daniel-N-Huss // @stevenjackson , Appreciate that this gem hasn't been bumped in a little bit so I'm not sure if you're actively maintaining/accepting PRs currently, but would be great to get a review and see what your thoughts are if you're open to changes. |
|
👋 Hey @jamesoneill997! I've got it on my list to take a look at this. I should have a bit of time in the next week to put some eyes here. Much appreciated! |
|
Thanks Daniel, much appreciated 🙏😁 |
Because we're not really filtering until after we get specs back from our query, I think moving this to change what Results we're returned is a more natural fit. Co-Authored-By: James O'Neill <36668255+jamesoneill997@users.noreply.github.com>
I'm going to pack this up with some other changes for the next bump
|
@jamesoneill997 I appreciate the thoughtful addition! I wouldn't have considered this a CI tool, so I think it's neat you want to apply it that way. Couple notes about the poking I did. I'll merge with these changes, but am always happy to discuss and fix forward.
💚 Thanks for taking the time. |
|
Thanks very much for that @Daniel-N-Huss , I appreciate the input and detailed response! It's a nice gem, you've done a great job with it. I'm more than happy to contribute on any of the features that you're looking to add if it's any help. Looking forward to seeing the next release, all the best! 😁 |
This PR allows for users to identify gems that haven't been updated in a defined amount of time with an --older-than flag. This is useful because it can be added to automated checks during CI to help developers identify gems that have been abandoned or are no longer actively maintained.
Example output:
I hope that you don't mind me creating this PR out of the blue, and I hope that you find it useful. I'm happy to make any changes that you think are suitable.
Thanks in advance!