Add ffmpeg to fix testcontainers/testcontainers-java#512 #4
Conversation
Dockerfile
Outdated
|
|
||
| RUN pip install vnc2flv | ||
| # INSTALL ffmpeg | ||
| ADD https://johnvansickle.com/ffmpeg/releases/ffmpeg-release-amd64-static.tar.xz . |
There was a problem hiding this comment.
I was thinking it might be possible to install this via apt, but probably ffmpeg contains non-codecs and is therefore not in Debian package repositories?
There was a problem hiding this comment.
Ok, it seems newer Debian version contain ffmpeg. So this would mean e.g. updating the image to debian:buster-slim, which sounds fine to me in general.
There was a problem hiding this comment.
Indeed It was the easiest solution, but I had some difficulties at the beginning to install ffmpeg via apt, as stated in Debian wiki page, it is not available for Debian 8.
...So I thought of two solutions:
- Compile and install it from the source code
- Or Use the available static version, which is mentioned in ffmpeg official download page under Linux Static Builds.
There was a problem hiding this comment.
What about upgrading the image to a newer Debian version? I would prefer this approach if it works.I checked and ffmpeg is available in e.g. buster.
Dockerfile
Outdated
|
|
||
| RUN pip install vnc2flv | ||
| # INSTALL ffmpeg | ||
| ADD https://johnvansickle.com/ffmpeg/releases/ffmpeg-release-amd64-static.tar.xz . |
There was a problem hiding this comment.
Ok, it seems newer Debian version contain ffmpeg. So this would mean e.g. updating the image to debian:buster-slim, which sounds fine to me in general.
Dockerfile
Outdated
|
|
||
| RUN pip install vnc2flv | ||
| # INSTALL ffmpeg | ||
| ADD https://johnvansickle.com/ffmpeg/releases/ffmpeg-release-amd64-static.tar.xz . |
There was a problem hiding this comment.
What about upgrading the image to a newer Debian version? I would prefer this approach if it works.I checked and ffmpeg is available in e.g. buster.
Dockerfile
Outdated
| RUN apt-get update && \ | ||
| apt-get install -y ffmpeg=7:4.1.6-1~deb10u1 && \ | ||
| apt-get autoremove && apt-get clean && \ | ||
| ffmpeg -version |
There was a problem hiding this comment.
Sorry, one more thing to change:
Can you please move all those commands to the RUN command starting line 10?
Line10 should read like this I assume:
RUN apt-get update && apt-get install -y \
python-pip python-dev ffmpeg=7:4.1.6-1~deb10u1 \
&& rm -rf /var/lib/apt/lists/*
&& pip install vnc2flv \
&& rm -fr /tmp/*
This way we have minimal layers.
Is autoremove and clean necessary? There should be no useless packages coming in I would have assumed.
There was a problem hiding this comment.
thanks, it's Done.
|
Thanks! LGTM I will merge and cut a release. |
|
Thank you for working on this @oussamabadr 🙇♂️ |
|
You're welcome, thanks to you and to @kiview for following up 👍 |
In order to fix testcontainers/testcontainers-java#512, I added ffmpeg to this docker image.