Skip to content

Conversation

@Tranquility2
Copy link
Contributor

@Tranquility2 Tranquility2 commented Apr 11, 2025

TL;DR this is a cleanups and alignments

  • Update pre-commit ruff version to latest + adaptations needed

  • Fix some issues with the pyproject.toml file schemas.

    1. tool.poetry.source requires URL see
    2. tool.ruff.lint changed flake8-type-checking code checkout
    3. tool.mypy doest not support fast_module_lookup in the TOML (Need to investigate more if we want to add it back)

@codecov
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (main@e8bf224). Learn more about missing BASE report.

Files with missing lines Patch % Lines
core/testcontainers/core/docker_client.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #807   +/-   ##
=======================================
  Coverage        ?   85.86%           
=======================================
  Files           ?       12           
  Lines           ?      679           
  Branches        ?      105           
=======================================
  Hits            ?      583           
  Misses          ?       73           
  Partials        ?       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Tranquility2 Tranquility2 changed the title chore(main): Pyproject fixes chore(main): project fixes and updates Apr 11, 2025
@alexanderankin alexanderankin merged commit 408f5c2 into testcontainers:main May 4, 2025
39 checks passed
alexanderankin added a commit that referenced this pull request Jun 13, 2025
TL;DR this is a cleanups and alignments

- Update pre-commit ruff version to latest + adaptations needed

- Fix some issues with the pyproject.toml file schemas.
1. `tool.poetry.source` requires URL
[see](python-poetry/poetry#3855)
2. `tool.ruff.lint` changed flake8-type-checking code
[checkout](https://astral.sh/blog/ruff-v0.8.0)
3. `tool.mypy` doest not support `fast_module_lookup` in the TOML (Need
to investigate more if we want to add it back)

---------

Co-authored-by: David Ankin <daveankin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants