fix(opensearch): add support for admin_password in >= 2.12 #697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add support for opensearch >= 2.12
alexanderankin
changed the title
alexanderankin
pushed a commit
that referenced
this pull request
Oct 14, 2024
🤖 I have created a release *beep* *boop* --- ## [4.8.2](testcontainers-v4.8.1...testcontainers-v4.8.2) (2024-09-27) ### Bug Fixes * **core:** Reorganize core tests and improve ([#693](#693)) ([f1665f3](f1665f3)) * **core:** Typing in auth ([#691](#691)) ([66726b6](66726b6)) * **core:** Typing in config + utils ([#692](#692)) ([794a22e](794a22e)) * **keycloak:** Add support for Keycloak version >=25 ([#694](#694)) ([62bd0de](62bd0de)) * mysql typo ([#705](#705)) ([85d6078](85d6078)), closes [#689](#689) * **opensearch:** add support for admin_password in >= 2.12 ([#697](#697)) ([935693e](935693e)) * postgres use psql instead of logs ([#704](#704)) ([4365754](4365754)) * **tests:** Missing artifacts (include-hidden-files) ([#699](#699)) ([8f1165d](8f1165d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opensearch has made an initial admin password mandatory since version 2.12 as can be read in the changelogs.
The open search module in test containers-python does not pass in this additional flag and current compatibility with open search >= 2.12 is broken .
This MR adds compatibility with open search >= 2.12 by adding the inidial_admin_password flag to the docker environment