Skip to content

fix(core): add empty _configure to DockerContainer #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2024
Merged

fix(core): add empty _configure to DockerContainer #556

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07a575d
add empty _configure to DockerContainer
christianaaronschroeder Apr 24, 2024
93927f7
eol
alexanderankin May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions core/testcontainers/core/container.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ def start(self) -> Self:
Reaper.get_instance()
logger.info("Pulling image %s", self.image)
docker_client = self.get_docker_client()
self._configure()
self._container = docker_client.run(
self.image,
command=self._command,
Expand Down Expand Up @@ -176,6 +177,10 @@ def exec(self, command) -> tuple[int, str]:
raise ContainerStartException("Container should be started before executing a command")
return self._container.exec_run(command)

def _configure(self) -> None:
# placeholder if subclasses want to define this and use the default start method
pass


class Reaper:
_instance: "Optional[Reaper]" = None
Expand Down