Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Neo4j default password to support v5 #832

Merged
merged 4 commits into from
Sep 10, 2024

Conversation

EcksDy
Copy link
Contributor

@EcksDy EcksDy commented Sep 6, 2024

Fixes #831

I've considered adding a test against neo4j:latest tag, but it would inevitably start catching unrelated issues. It might be a good addition after all.

Copy link

netlify bot commented Sep 6, 2024

Deploy Preview for testcontainers-node ready!

Name Link
🔨 Latest commit b2704b5
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-node/deploys/66deac03a43eb300089d7066
😎 Deploy Preview https://deploy-preview-832--testcontainers-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@EcksDy EcksDy changed the title Changed default neo4j password fix: Changed default neo4j password for neo4j 5+ requirements Sep 6, 2024
@cristianrgreco cristianrgreco added bug Something isn't working patch Backward compatible bug fix labels Sep 6, 2024
@eddumelendez
Copy link
Member

Hi, thanks for your contribution. Can you please add a test using neo4j 5?

@EcksDy
Copy link
Contributor Author

EcksDy commented Sep 9, 2024

@eddumelendez
added a test against neo4j:v5

@cristianrgreco cristianrgreco changed the title fix: Changed default neo4j password for neo4j 5+ requirements Fix Neo4j default password to support v5 Sep 10, 2024
@cristianrgreco cristianrgreco merged commit f8f82a5 into testcontainers:main Sep 10, 2024
94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch Backward compatible bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Neo4j version 5+ requires a longer password
3 participants