Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logs around resolving a container runtime #787

Merged
merged 6 commits into from
Jun 28, 2024

Conversation

cristianrgreco
Copy link
Collaborator

To help debug #785

@cristianrgreco cristianrgreco added enhancement New feature or request patch Backward compatible bug fix labels Jun 25, 2024
Copy link

netlify bot commented Jun 25, 2024

Deploy Preview for testcontainers-node ready!

Name Link
🔨 Latest commit 6d771b1
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-node/deploys/667e7b27f3927f0008feda4a
😎 Deploy Preview https://deploy-preview-787--testcontainers-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cristianrgreco
Copy link
Collaborator Author

Unable to get the project to build after repeated attempts. Though the only change is the addition of logs, the GH action agents are failing to install dependencies. Either an issue with the agents or NPM 🤷

@jonesbusy
Copy link

Thanks, if you are able to release it I'm more that happy to test it and provide those logs

@cristianrgreco cristianrgreco merged commit 0f26b4a into main Jun 28, 2024
94 checks passed
@cristianrgreco cristianrgreco deleted the container-runtime-init-logs branch June 28, 2024 17:39
@jonesbusy
Copy link

Thanks but sadly I will not be able to test before 2 weeks. In any case I think those logs are useful.

So if anyone else want to test the future version and provide logs I'm very curious to know the cause of the issue

@cristianrgreco
Copy link
Collaborator Author

Thanks @jonesbusy. I think the issue may be specific to kubedock as I haven't heard anything else, so we may well have to wait for your return. Apologies this took so long to merge it turns out that https://github.com/marketplace/actions/rootless-docker has suddenly stopped working on the GH actions agents 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request patch Backward compatible bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants