Added builder for timeouts in JdbcDatabaseContainer (#715)#748
Added builder for timeouts in JdbcDatabaseContainer (#715)#748bsideup merged 2 commits intotestcontainers:masterfrom
Conversation
|
Seems like a pretty good idea and it's just a small change. On the other hand, see this comment by @vpavic:
So maybe |
| @@ -190,13 +215,13 @@ public void addParameter(String paramName, String value) { | |||
| * @return startup time to allow, including image pull time, in seconds | |||
| */ | |||
| protected int getStartupTimeoutSeconds() { | |||
There was a problem hiding this comment.
OracleContainer is overriding this method, so this PR should also change OracleContainer to use fluent-setter to set it's default value.
|
Initially I wanted to put setting the default timeouts into the configure-method but this would override values which where set by the user. |
Added builder functionality for timeouts in JdbcDatabaseContainer to improve usability for e.g. MS SQL Server image which needs much more time to start up.
I have seen the workaround with override from @vpavic at #715 and made it configurable by builder pattern to increase usability.
@kiview or @rnorth may take a look at it?