Demote "testcontainers.properties not found" message to debug log level#7035
Merged
eddumelendez merged 1 commit intotestcontainers:mainfrom May 30, 2023
Merged
Demote "testcontainers.properties not found" message to debug log level#7035eddumelendez merged 1 commit intotestcontainers:mainfrom
eddumelendez merged 1 commit intotestcontainers:mainfrom
Conversation
eddumelendez
approved these changes
May 30, 2023
Member
|
Thanks for your contribution, @perlun ! I think debug level makes sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These warnings are mostly annoying, causing noise in CI logs. They can of course be silenced using e.g. the Logback configuration, but I think it's better to demote these warnings here. They are not really warnings per se, just Testcontainers letting you know that the (optional) configuration isn't present.