Fixed HostPortWaitStrategy throws NumberFormatException when port is exposed but not mapped#640
Merged
bsideup merged 2 commits intotestcontainers:masterfrom Apr 11, 2018
barrycommins:640
Merged
Fixed HostPortWaitStrategy throws NumberFormatException when port is exposed but not mapped#640bsideup merged 2 commits intotestcontainers:masterfrom barrycommins:640
HostPortWaitStrategy throws NumberFormatException when port is exposed but not mapped#640bsideup merged 2 commits intotestcontainers:masterfrom
barrycommins:640
Conversation
when port is exposed but not mapped
bsideup
requested changes
Apr 11, 2018
|
|
||
| public class DockerComposeExposedPortTest { | ||
|
|
||
| @Rule |
Member
There was a problem hiding this comment.
could you please convert it to try-with-resources-style and maybe just add to some other Docker Compose test
Contributor
Author
|
Updated as suggested. I just added an exposed port to one of the existing test docker-compose files, which causes several existing tests to fail without the fix, but pass with the fix. |
bsideup
approved these changes
Apr 11, 2018
Member
|
@barrycommins merged, thanks! 👍 |
|
Are there any plans to release 1.7.1? |
Member
|
@ilkinulas yes, we will do a hotfix release later this week :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports that were exposed but not mapped to a host port were throwing
NumberFormatExceptionwhengetMappedPort()was called onContainerState.E.g.