Fixed docker-compose examples in docs#623
Merged
bsideup merged 1 commit intotestcontainers:masterfrom Mar 25, 2018
barrycommins:compose-docs
Merged
Fixed docker-compose examples in docs#623bsideup merged 1 commit intotestcontainers:masterfrom barrycommins:compose-docs
bsideup merged 1 commit intotestcontainers:masterfrom
barrycommins:compose-docs
Conversation
Member
|
@barrycommins Missed that during the code review as well, thanks for checking 👍 💯 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realise from #620 that some of the docker-compose
WaitStrategyexamples are incorrect.I forgot to update them during the PR changes for #600.
I've also updated some of the wording for the Ambassador containers to better reflect the current implementation.