Use HttpWaitStrategy for SimpleNginxTest#590
Merged
Conversation
To ensure proper waits and avoid race conditions (flaky test)
bsideup
approved these changes
Feb 25, 2018
Member
|
@rnorth I feel like having a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To ensure proper waits and avoid race conditions (flaky test)
Since the Gradle migration we've been seeing a lot of the following stack trace. I have no idea why, but I suspect an improvement in test execution speed might have uncovered a previously hidden timing bug in our tests:
This PR simply attaches an HttpWaitStrategy to the test. We could have added this to the
NginxContaineritself, but I felt that would be counterproductive: users will typically need to customise the http wait strategy according to their nginx configuration, so we should leave it to them.