Add editorconfig for a degree of IDE formatting consistency#588
Add editorconfig for a degree of IDE formatting consistency#588
Conversation
| root = true | ||
|
|
||
| # Unix-style newlines with a newline ending every file | ||
| [*] |
There was a problem hiding this comment.
Tempted to leave this as just *.java - thoughts?
There was a problem hiding this comment.
I checked a few other projects, they seem to use [*]
Also, I recommend adding:
[*.md]
trim_trailing_whitespace = false
Because in Markdown there is (two trailing spaces) to break the line
There was a problem hiding this comment.
Plus trim_trailing_whitespace = true to [*]
There was a problem hiding this comment.
Good idea, will do. Thanks!
There was a problem hiding this comment.
I think it's good to have lf for all files, especially bash files, to make life easier for Windows development (currently we've solved this with the .gitattributes). And this might also help us in achieving remote caching for Windows builds for local development (not for CI though?).
There was a problem hiding this comment.
Hm no, it doesn't help with Windows cache, since it's only applied for edited files? But it's fine, we can solve it another way some day ;)
| root = true | ||
|
|
||
| # Unix-style newlines with a newline ending every file | ||
| [*] |
There was a problem hiding this comment.
I think it's good to have lf for all files, especially bash files, to make life easier for Windows development (currently we've solved this with the .gitattributes). And this might also help us in achieving remote caching for Windows builds for local development (not for CI though?).
| root = true | ||
|
|
||
| # Unix-style newlines with a newline ending every file | ||
| [*] |
There was a problem hiding this comment.
Hm no, it doesn't help with Windows cache, since it's only applied for edited files? But it's fine, we can solve it another way some day ;)
3 participants
This is intended to start moving us towards more consistent code formatting.
It will hopefully help make new contributions' formatting be more consistent. This PR doesn't include a bulk reformatting of the codebase, as that would probably be more pain for PR authors that they don't need right now.
WDYT?