Improve the usability of GenericContainer#550
Merged
Conversation
Member
|
@bsideup CircleCI failure? https://circleci.com/gh/testcontainers/testcontainers-java/829 |
rnorth
reviewed
Jan 21, 2018
| */ | ||
| SELF withLogConsumer(Consumer<OutputFrame> consumer); | ||
|
|
||
| @Deprecated |
Member
There was a problem hiding this comment.
Is this related to the change? Same question for deprecation getContainerInfo().
I don't mind deprecating these, as it makes things cleaner, but would it be possible to have a comment indicating a recommended alternative approach?
rnorth
requested changes
Jan 21, 2018
Member
Author
|
@rnorth CircleCI failed because it was using the old configuration: I've added deprecation notes and entries to CHANGELOG.md :) |
rnorth
approved these changes
Jan 27, 2018
1a07fad to
72f99af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed:
withEnvwith mapper:READ_WRITEbind mode if none was provided:Also deprecated some methods from
Containerinterface likefetchDockerDaemonInfobecause we don't want to have them in our public API