Fix docker-compose executable check for Win10 (#460)

[bsnisar]

This is fix for issue: #460

[kiview]

Do we run tests for local compose on Windows? I have to check at home on my Windows box.

I also wonder how https://github.com/bsnisar/testcontainers-java/blob/61d9b0e1972a8be0530d22368ee9ff200172ca6d/core/src/main/java/org/testcontainers/containers/DockerComposeContainer.java#L512 works, if we have to append .exe on Windows.

[kiview]

I think I would prefer to make the value of COMPOSE_EXECUTABLE OS dependent, if that's what we also need when calling the docker-compose executable.

[kiview]

I think we can omit this comment (or change it to correct Javadoc comment syntax, but I prefer omitting it).

[bsnisar]

Agree

[kiview]

I would prefer renaming the method to something like dockerComposeExecutableExists.

[bsnisar]

Hi @kiview , in my case for Win10 docker-compose is accessible locally on my cmd:

But during the check inside CommandLine(executable = "docker-compose"):

    for (String pathString : getSystemPath()) {
        Path path = Paths.get(pathString);
        if (Files.exists(path.resolve(executable)) && Files.isExecutable(path.resolve(executable))) {
            return true;
        }
    }

this loop will find (among other locations) somthing like C:\Program Files\Docker\Docker\Resources\bin where no docker-compose file:

C:\Program Files\Docker\Docker\resources\bin>dir
Volume in drive C is Windows
Volume Serial Number is 8408-CF1E

Directory of C:\Program Files\Docker\Docker\resources\bin

09/10/2017 12:51 PM

.
09/10/2017 12:51 PM ..
09/10/2017 12:51 PM 6,380,236 docker-compose.exe
09/10/2017 12:51 PM 2,436,096 docker-credential-wincred.exe
09/10/2017 12:51 PM 26,885,120 docker-machine.exe
09/10/2017 12:51 PM 19,135,488 docker.exe
09/10/2017 12:51 PM 8,162,816 notary.exe

As a result even if the command is executable, run will be failed by

    if (!CommandLine.executableExists(COMPOSE_EXECUTABLE)) {
        throw new ContainerLaunchException("Local Docker Compose not found. Is " + COMPOSE_EXECUTABLE + " on the PATH?");
    }

So, for me simple fix for executable check looks good enough to satisfy this case.

[kiview]

What if we change this method to:

        if (SystemUtils.IS_OS_WINDOWS) {
            return CommandLine.executableExists(COMPOSE_EXECUTABLE + ".exe");
        } else {
           return CommandLine.executableExists(COMPOSE_EXECUTABLE);
        }

[bsnisar]

This variant more readable and looks better, but narrows all possible options to *.exe variant on Win machines.
How docker-compose executable looks on other Win platforms (not Win10) ?

[kiview]

Since we currently only support Docker for Windows on Windows 10 (see Windows support), I would be fine with this.

[bsnisar]

In this case I will rewrite it.

Also, what about this variant:

    return SystemUtils.IS_OS_WINDOWS 
            ? CommandLine.executableExists(COMPOSE_EXECUTABLE + ".exe")
            : CommandLine.executableExists(COMPOSE_EXECUTABLE);

[kiview]

Since we currently only support Docker for Windows on Windows 10 (see Windows support), I would be fine with this.

[kiview]

@bsnisar Can you please also update the CHANGELOG.md file, by referencing #460 in the line about the docker-compose fix? I'll merge afterwards.

[bsnisar]

@kiview I have updated it.
Also, as I can see there is a fix for similar problem that was merged. Is it reasonable to merge this PR after that?

[kiview]

What I meant, was referencing both issues here ;)

[bsnisar]

@kiview Ouh, its my misstate. I have just fixed it.

[ahrytsiuk]

@bsnisar @kiview Seems the issue is still remains.
Because on Windows OS the .exe suffix is appended twice to COMPOSE_EXECUTABLE.
First time here:

testcontainers-java/core/src/main/java/org/testcontainers/containers/DockerComposeContainer.java

Line 468 in 540f567

private static final String COMPOSE_EXECUTABLE = SystemUtils.IS_OS_WINDOWS ? "docker-compose.exe" : "docker-compose";

private static final String COMPOSE_EXECUTABLE = SystemUtils.IS_OS_WINDOWS ? "docker-compose.exe" : "docker-compose";

And second time here:

testcontainers-java/core/src/main/java/org/testcontainers/containers/DockerComposeContainer.java

Line 536 in 540f567

return CommandLine.executableExists(COMPOSE_EXECUTABLE + ".exe");

private boolean dockerComposeExecutableExists() {
        if (SystemUtils.IS_OS_WINDOWS) {
            return CommandLine.executableExists(COMPOSE_EXECUTABLE + ".exe");
        } else {
            return CommandLine.executableExists(COMPOSE_EXECUTABLE);
        }
}

UPD:
As I understood, when you merged this PR it just broke docker-compose on Windows OS