Couchbase: Update to latest version, add flushEnabled flag #4041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Gerschtli I hope you don't mind if I resolve the current merge conflicts! |
daschl
suggested changes
Jun 16, 2021
modules/couchbase/src/main/java/org/testcontainers/couchbase/CouchbaseContainer.java
Outdated
Show resolved
Hide resolved
Gerschtli
force-pushed
the
update-couchbase
branch
from
0ecfcea to
c882cd1
Compare
|
I removed the community support out of this PR. When this PR is merged, I can open a follow up PR. |
daschl
suggested changes
Jun 24, 2021
modules/couchbase/src/test/java/org/testcontainers/couchbase/CouchbaseContainerTest.java
Show resolved
Hide resolved
Gerschtli
force-pushed
the
update-couchbase
branch
from
c882cd1 to
1c50487
Compare
daschl
approved these changes
Jun 26, 2021
rnorth
approved these changes
Jun 29, 2021
There was a problem hiding this comment.
Looks good to me. Thank you @Gerschtli, and thanks @daschl for your help with this!
rnorth
changed the title
|
Follow up PR for community support: #4221 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey folks,
for easier usage for any new user of couchbase I upgraded the couchbase library, so that the snippets in the documentation are up-to-date and simply work :)
Furthermore, I added support for the
flushEnabledflag for buckets. Pretty handy option to simplify usage in tests for easier cleanup.Lastly, I added a
communityModewhich changes when enabled thestorageModefor indexes toforestdb(the only supported mode for community edition).Thank you all for this great project!