Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gitlab: add information for TLS disabled mode #2466

Merged
merged 2 commits into from
Apr 7, 2021
Merged

Gitlab: add information for TLS disabled mode #2466

merged 2 commits into from
Apr 7, 2021

Conversation

pmihalcin
Copy link
Contributor

The Docker daemon supports connection over TLS and it’s done by default for Docker 19.03.1 or higher.
We need to instruct docker to not start over TLS with DOCKER_TLS_CERTDIR variable

@pmihalcin
Add information for TLS disabled mode
fbd4c1f 
The Docker daemon supports connection over TLS and it’s done by default for Docker 19.03.1 or higher.
We need to instruct docker to not start over TLS with DOCKER_TLS_CERTDIR variable
@bsideup
Copy link
Member

bsideup commented Mar 20, 2020

@kiview WDYT?

@bsideup bsideup changed the title Add information for TLS disabled mode Gitlab: add information for TLS disabled mode Mar 20, 2020
@stale
Copy link

stale bot commented Aug 6, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this.

@stale stale bot added the stale label Aug 6, 2020
@pmihalcin
Copy link
Contributor Author

@bsideup @rnorth @kiview Do you happen to have any updates on this documentation improvement?

kiview
kiview requested changes Aug 6, 2020
View reviewed changes
Copy link
Member

@kiview kiview left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @pmihalcin,

sorry I missed this PR. Can you address my question? Then we can merge ASAP.

docs/supported_docker_environment/continuous_integration/gitlab_ci.md Show resolved Hide resolved
@stale stale bot removed the stale label Aug 6, 2020
@pmihalcin pmihalcin requested a review from kiview August 6, 2020 13:10
@stale
Copy link

stale bot commented Jan 24, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this.

@stale stale bot added the stale label Jan 24, 2021
@stale stale bot removed the stale label Jan 24, 2021
@bsideup
Copy link
Member

bsideup commented Jan 24, 2021

@kiview ping

@bsideup bsideup added this to the next milestone Apr 7, 2021
@kiview
Copy link
Member

kiview commented Apr 7, 2021

@pmihalcin I am super sorry for missing this, your remarks were 100% correct.

@kiview kiview merged commit b3cf062 into testcontainers:master Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiview kiview kiview approved these changes

@bsideup bsideup Awaiting requested review from bsideup

@rnorth rnorth Awaiting requested review from rnorth

Assignees
No one assigned
Labels
resolution/acknowledged type/docs
Projects
None yet
Milestone
1.15.3
Development

Successfully merging this pull request may close these issues.
4 participants
@pmihalcin @bsideup @kiview @rnorth