ISSUE-1327 start ambassador only if mapping configured

[ftardif]

fix #1121
edit: that was a typo, this PR fix: #1327

[bsideup]

Hi @ftardif,

Thanks a lot for fixing it! Could you please add a simple test to verify the fix?

[ftardif]

Do you have a strategy to test these kind of behaviours? I cannot do a unit test by mocking the ambassador generic container because it is instantiated within the class. And I am not too sure how I could do an integration test to verify that socat container is not launched. Any recommendation?

[bsideup]

@ftardif AFAIR it will fail if there are no ports exposed, right? Can we test it?

[ftardif]

No the idea is to work, but without the socat container, only the ryuk and actual containers unwind from the compose file. When the containers already have host port exposed, we can use these for waiting strategies, hence the basic socat check becomes un relevant.

[ftardif]

this PR is meant to fix : #1327

[bsideup]

reported #1331, will merge this one without a test

[trajano]

So is #1121 fixed for this is it still a typo?

[bsideup]

@ftardif thanks for your contribution! 👍

@trajano I think #1121 is a different problem

[trajano]

OK because it was marked as closed due to this PR.

[rnorth]

Releasing this in 1.11.0 🎉