Update Neo4j default image to 5.26 (LTS). #10613
Open
+25
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will not only update the test image but also clean up usage of `withEnterpriseEdition` to just append the `-enterprise` suffix instead of pulling in the former neo4j:4.4 default image without users noting the implicit change from their defined image version.
| @@ -211,8 +206,7 @@ public Neo4jContainer withEnterpriseEdition() { | |||
| String.format("Cannot use enterprise version with alternative image %s.", getDockerImageName()) | |||
| ); | |||
| } | |||
|
|
|||
| setDockerImageName(DEFAULT_IMAGE_NAME.withTag(ENTERPRISE_TAG).asCanonicalNameString()); | |||
| setDockerImageName(DockerImageName.parse(getDockerImageName() + ENTERPRISE_SUFFIX).asCanonicalNameString()); | |||
There was a problem hiding this comment.
this will break existing users. Why not improve the exception's message?
There was a problem hiding this comment.
From a technical, formal perspective I would say, that you are right.
But (of course) I would consider this as a bug that came as a left-over when we've removed the default constructor that fell back to the default image name.
I think that nobody would expect working with a neo4j:5.26 image to get ported back to the previous major version (4.4) when enabling enterprise per API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will not only update the test image but also clean up usage of
withEnterpriseEditionto just appendthe
-enterprisesuffix instead of pulling in the former neo4j:4.4 default image without users noting the implicit change from their defined image version.