-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add InfluxDB v3 support #10596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add InfluxDB v3 support #10596
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. I've left some comments. Please, also add some docs.
modules/influxdb/src/main/java/org/testcontainers/containers/InfluxDBContainerV3.java
Outdated
Show resolved
Hide resolved
modules/influxdb/src/main/java/org/testcontainers/containers/InfluxDBContainerV3.java
Outdated
Show resolved
Hide resolved
modules/influxdb/src/main/java/org/testcontainers/containers/InfluxDBContainerV3.java
Outdated
Show resolved
Hide resolved
modules/influxdb/src/main/java/org/testcontainers/containers/InfluxDBContainerV3.java
Outdated
Show resolved
Hide resolved
modules/influxdb/src/main/java/org/testcontainers/containers/InfluxDBContainerV3.java
Outdated
Show resolved
Hide resolved
modules/influxdb/src/main/java/org/testcontainers/containers/InfluxDBContainerV3.java
Outdated
Show resolved
Hide resolved
modules/influxdb/src/main/java/org/testcontainers/containers/InfluxDBContainerV3.java
Outdated
Show resolved
Hide resolved
modules/influxdb/src/main/java/org/testcontainers/containers/InfluxDBContainerV3.java
Outdated
Show resolved
Hide resolved
modules/influxdb/src/main/java/org/testcontainers/containers/InfluxDBContainerV3.java
Outdated
Show resolved
Hide resolved
modules/influxdb/src/main/java/org/testcontainers/containers/InfluxDBContainerV3.java
Outdated
Show resolved
Hide resolved
Fix it |
modules/influxdb/src/main/java/org/testcontainers/influxdb/InfluxDBContainer.java
Outdated
Show resolved
Hide resolved
modules/influxdb/src/main/java/org/testcontainers/influxdb/InfluxDBContainer.java
Outdated
Show resolved
Hide resolved
modules/influxdb/src/main/java/org/testcontainers/influxdb/InfluxDBContainer.java
Outdated
Show resolved
Hide resolved
modules/influxdb/src/test/java/org/testcontainers/containers/InfluxDBContainerV3Test.java
Outdated
Show resolved
Hide resolved
modules/influxdb/src/test/java/org/testcontainers/containers/InfluxDBContainerV3Test.java
Outdated
Show resolved
Hide resolved
modules/influxdb/build.gradle
Outdated
test { | ||
jvmArgs = [ | ||
"--add-opens=java.base/java.nio=org.apache.arrow.memory.core,ALL-UNNAMED", | ||
"--add-opens=java.base/sun.nio.ch=ALL-UNNAMED" | ||
] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this really needed? I don't think other modules need that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that this this "--add-opens=java.base/sun.nio.ch=ALL-UNNAMED" unnecessary but
influxdb3-java use
<dependency>
<groupId>org.apache.arrow</groupId>
<artifactId>flight-core</artifactId>
<version>18.3.0</version>
</dependency>
https://arrow.apache.org/docs/java/install.html Here is the reason why you should use --add-opens=java.base/java.nio=org.apache.arrow.memory.core,ALL-UNNAMED
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't this be only in effect, if we would use the module path?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without this
test {
jvmArgs = [
"--add-opens=java.base/java.nio=org.apache.arrow.memory.core,ALL-UNNAMED"
]
}
when I try to read data from the database, I get the errors described here https://arrow.apache.org/docs/java/install.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kiview do you have any other ideas?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eddumelendez Hello! Can you review it again?
Fixes #10451