Skip to content

Conversation

sbushmelev
Copy link
Contributor

@sbushmelev sbushmelev commented Aug 10, 2025

Fixes #10451

@sbushmelev sbushmelev changed the title Add Influx db v3 support https://github.com/testcontainers/testcontainers-java/issues/10451 Aug 10, 2025
@sbushmelev sbushmelev changed the title https://github.com/testcontainers/testcontainers-java/issues/10451 feature: https://github.com/testcontainers/testcontainers-java/issues/10451 Aug 10, 2025
@eddumelendez eddumelendez changed the title feature: https://github.com/testcontainers/testcontainers-java/issues/10451 Add InfluxDB v3 support Aug 12, 2025
Copy link
Member

@eddumelendez eddumelendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. I've left some comments. Please, also add some docs.

@sbushmelev
Copy link
Contributor Author

Fix it

Comment on lines 14 to 19
test {
jvmArgs = [
"--add-opens=java.base/java.nio=org.apache.arrow.memory.core,ALL-UNNAMED",
"--add-opens=java.base/sun.nio.ch=ALL-UNNAMED"
]
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this really needed? I don't think other modules need that.

Copy link
Contributor Author

@sbushmelev sbushmelev Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that this this "--add-opens=java.base/sun.nio.ch=ALL-UNNAMED" unnecessary but
influxdb3-java use

<dependency>
            <groupId>org.apache.arrow</groupId>
            <artifactId>flight-core</artifactId>
            <version>18.3.0</version>
     </dependency>

https://arrow.apache.org/docs/java/install.html Here is the reason why you should use --add-opens=java.base/java.nio=org.apache.arrow.memory.core,ALL-UNNAMED

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this be only in effect, if we would use the module path?

Copy link
Contributor Author

@sbushmelev sbushmelev Aug 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this

test {
    jvmArgs = [
        "--add-opens=java.base/java.nio=org.apache.arrow.memory.core,ALL-UNNAMED"
    ]
}

when I try to read data from the database, I get the errors described here https://arrow.apache.org/docs/java/install.html

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kiview do you have any other ideas?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eddumelendez Hello! Can you review it again?

@sbushmelev sbushmelev requested a review from a team as a code owner August 14, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Support InfluxDB v3
3 participants