Add DockerImageName constructors to ComposeContainer#10356
Closed
chinwobble wants to merge 14 commits intotestcontainers:mainfrom
Closed
Add DockerImageName constructors to ComposeContainer#10356chinwobble wants to merge 14 commits intotestcontainers:mainfrom
chinwobble wants to merge 14 commits intotestcontainers:mainfrom
Conversation
…propriate docker image in the ComposeContainer.
…ion of docker and update the constructors
…vVarOrUserProperty checking if the value is not empty
|
LGTM |
chinwobble
changed the title
Member
|
Hi @chinwobble, this PR only contains a rebase. #9871 is still valid, it doesn't have any conflict in order to perform the rebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the #9222 a user is specifying a property with the field name compose.container.image and the ComposeContainer when it creates the composeDelegate variable is always picking the 24.0.2 version of docker. The change that I am proposing is to use the TestcontainersConfiguration in order to parse the property compose.container.image if it exists otherwise continue as it was in the past. Updated the constructors based on the feedback.
@fokion I've rebased your branch.