Pass start command required in Solr 10#10174
Merged
eddumelendez merged 2 commits intotestcontainers:mainfrom Apr 7, 2025
Merged
Pass start command required in Solr 10#10174eddumelendez merged 2 commits intotestcontainers:mainfrom
start command required in Solr 10#10174eddumelendez merged 2 commits intotestcontainers:mainfrom
Conversation
Member
|
Hi @epugh, thanks for your contribution. Do you mind adding a test with version 10.x? |
Contributor
Author
10x hasn't yet been released (sometime in May to June-ish timeframe) so I don't think I can add the test. Having said that, I'll definitly provide a test when we have a release available. The addition of the word "start" is compatible with 8 and 9, and will be required in 10. |
eddumelendez
changed the title
start command required in Solr 10
Member
|
Thanks again for your contribution, @epugh! Glad to see those changes are backward compatible and will make the module ready to support the upcoming Solr version. |
Contributor
Author
|
My pleasure! I apprecaite your comments, and it made it a pleasant experience to contribute ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 10x we removed the short cut that "bin/solr" was a call to "bin/solr start", now we require you to specify what subcommand you want. This change is backwards compatible with 8x and 9x, and forwards compatible with the upcoming Solr 10 release.