BrowserWebDriverContainer configure does overwrite no_proxy environment variable

[roamingthings]

Hi,

I've noticed that the configure() method of BrowserWebDriverContainer is setting the environment variable to localhost regardless of another value that might already been present. This means that it is not possible to set a custom no_proxy value:

    @Rule
    public final BrowserWebDriverContainer chromeWithProxy = (BrowserWebDriverContainer) new BrowserNoProxyWebDriverContainer()
            .withDesiredCapabilities(chrome())
            .withRecordingMode(RECORD_ALL, new File("."))
            .withEnv("HTTP_PROXY", "http://my.proxy.com:8080")
            .withEnv("HTTPS_PROXY", "https://my.proxy.com:8080")
            .withEnv("no_proxy", "localhost,.noproxy-domain.com");

I've implemented a fix to this issue
roamingthings@4ed091b

Regards,
Alex

[kiview]

Hi @roamingthings, looks good, would you like to provide the PR?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this.

[stale]

This issue has been automatically closed due to inactivity. We apologise if this is still an active problem for you, and would ask you to re-open the issue if this is the case.