Add additional constructor to OracleContainer (#734)

testcontainers · Jun 12, 2018 · 2affee9 · 2affee9
1 parent c7d8a65
commit 2affee9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,6 +12,7 @@ All notable changes to this project will be documented in this file.
 - Use `quay.io/testcontainers/ryuk` instead of `bsideup/ryuk` ([\#721](https://github.com/testcontainers/testcontainers-java/pull/721))
 - Added Couchbase module ([\#688](https://github.com/testcontainers/testcontainers-java/pull/688))
 - Changed **internal** port of KafkaContainer back to 9092 ([\#733](https://github.com/testcontainers/testcontainers-java/pull/733))
+- Add support for Dockerfile based images to OracleContainer ([\#734](https://github.com/testcontainers/testcontainers-java/pull/734))
 
 ## [1.7.3] - 2018-05-16
 

diff --git a/modules/oracle-xe/src/main/java/org/testcontainers/containers/OracleContainer.java b/modules/oracle-xe/src/main/java/org/testcontainers/containers/OracleContainer.java
@@ -2,6 +2,8 @@
 
 import org.testcontainers.utility.TestcontainersConfiguration;
 
+import java.util.concurrent.Future;
+
 /**
  * @author gusohal
  */
@@ -32,6 +34,10 @@ public OracleContainer(String dockerImageName) {
         super(dockerImageName);
     }
 
+    public OracleContainer(Future<String> dockerImageName) {
+        super(dockerImageName);
+    }
+
     @Override
     protected Integer getLivenessCheckPort() {
         return getMappedPort(ORACLE_PORT);