Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: close response body in http strategy #718

Merged
merged 2 commits into from
Dec 31, 2022
Merged

fix: close response body in http strategy #718

merged 2 commits into from
Dec 31, 2022

Commits on Dec 30, 2022

  1. fix: close response body in http strategy 

    From to the documentation:
> If the returned error is nil, the Response will contain a non-nil body
which the user is expected to close.

Failed requests (due to wrong response or status code) were leaving
open connections.
Close the response body according to the documentation.
    @kruskall
    kruskall committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    638c0d3 View commit details
    Browse the repository at this point in the history

  2. lint: assign error to empty var

    @kruskall
    kruskall committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    bfb296d View commit details
    Browse the repository at this point in the history