Repository navigation
fix: format MountType with %v in bind mount diagnostic - #3915
vulragrag-star wants to merge 1 commit into
Conversation
BindMounter logging used %s with MountType (a uint), which produced a fmt error marker instead of the type value. Use %v so the diagnostic is readable. Refs: testcontainers#3909
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review. Summary by CodeRabbit
WalkthroughThe unsupported mount diagnostic now formats the mount type with ChangesMount Diagnostic Formatting
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~5 minutes Change: Bug fix · Severity of issue fixed: Low Suggested reviewers: Merge Risk: ⚪ Minimal · up to The diagnostic formatting issue is addressed and covered by a focused test; no material merge risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the mount log line, Comment |
What does this PR do?
In
mapToDockerMounts, theBindMounterdiagnostic used%swithMountType(auintwith noStringmethod). That produces a fmt error marker such as%!s(testcontainers.MountType=0)instead of the type value. This changes the verb to%vand adds a unit test for the diagnostic format.Why is it important?
Unsupported-bind-mount errors should show a readable mount type so the diagnostic is usable when debugging mount configuration.
Related issues
How to test this PR