Skip to content

Conversation

@HofmeisterAn
Copy link
Collaborator

What does this PR do?

The PR prevents Testcontainers from creating a Port Forwarding Container instance if auto-discovery does not detect a Docker host.

Why is it important?

If users choose to configure their Docker host environment individually using the container builder method WithDockerEndpoint, Testcontainers will throw an exception

Cannot detect the Docker endpoint. [...]

if auto-discovery fails to find a Docker host environment. The port forwarding container depends on auto-discovery and cannot be customized for individual Docker host configurations since it is implemented as a singleton.

To enhance the user experience, we should consider removing feature WithDockerEndpoint. By relying on auto-discovery, we can better support a wide range of features in Testcontainers and simplify test configurations.

Related issues

-

@HofmeisterAn HofmeisterAn added the bug Something isn't working label May 22, 2023
@netlify
Copy link

netlify bot commented May 22, 2023

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit 5771043
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/646b4df0184ad50008a604dd
😎 Deploy Preview https://deploy-preview-900--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@HofmeisterAn HofmeisterAn merged commit 12571d7 into develop May 22, 2023
@HofmeisterAn HofmeisterAn deleted the bugfix/do-not-create-pfc branch May 22, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant