-
-
Notifications
You must be signed in to change notification settings - Fork 339
chore: Make the continuous delivery job fork-friendly #1559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary by CodeRabbit
WalkthroughRequire the CI/CD workflow to run only when both the repository matches Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer (push/pr)
participant GH as GitHub
participant WF as cicd.yml (workflow)
Dev->>GH: push / open PR
GH->>WF: evaluate workflow triggers
note right of WF #DDEBF7: Condition: repo == "testcontainers/testcontainers-dotnet"\nand branch in ["develop","main"]
alt Condition met
WF->>WF: run deployment jobs
WF-->GH: report success/failure
else Condition not met
WF-->GH: skip deployment (no job run)
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/cicd.yml(1 hunks)Testcontainers.sln(2 hunks)
🔇 Additional comments (1)
.github/workflows/cicd.yml (1)
92-92: LGTM! Repository check correctly prevents fork execution.The CD job now requires both the correct repository and branch, preventing failures on forks where secrets are unavailable.
That is, run it only from the testcontainers/testcontainers-dotnet repository. The secrets required for the `cd` job to run successfully won't be configured in the forks anyway.
c027999 to
293d43f
Compare
What does this PR do?
Run the continuous delivery job only from the testcontainers/testcontainers-dotnet repository.
The secrets required for the
cdjob to run successfully won't be configured in the forks anyway.Why is it important?
The continuous delivery job has no reason to be run from forks. It will just end up with errors.
Related issues
N/A