fix(Keycloak): Wait until user created #1535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds another wait strategy to the Keycloak module. In addition to waiting for the health API, the module now also waits until one of these log messages appears:
Added user '[^']+' to realm '[^']+'|Created temporary admin user with username \S+.I ran the tests for a while in a GH Codespaces environment (which behaves more like our CI) and didn't run into any issues.
Why is it important?
Our CI occasionally fails with stack traces that indicates Keycloak isn't fully ready to handle requests. It seems that the user setup wasn't complete, causing authentication against the instance to fail.
Related issues
FlurlHttpException : Call failed with status code 401 (Unauthorized)) #1533