docs: Extend example copying files to a container #1487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an example for copying to a file. This should make it more explicit that, when providing a string, the target is a directory, not a file. For a file to be a target, a `FileInfo` must be passed. Relates to testcontainers#1486
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
HofmeisterAn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change should make it more explicit that, when providing a string, the target is always a directory and never a file path. To specify a file path, a instance of
FileInfomust be passed.Why is it important?
When coming from
docker-compose.yml, it is unexpected that the second argument ofWithResourceMappingis always a path to a directory, never a file.Given
.WithResourceMapping(new FileInfo("file.txt"), "/file.txt");, my expectation was a file at/file.txt, but it ends up at/file.txt/file.txtin the container.Related issues
Relates to #1486