fix: Retrieve logs since CreatedTime for UntilMessageIsLogged wait strategy
#1384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Retrieve logs since `CreatedTime` to ensure that logs from the previous run are ignored and only logs from the current run are processed. Fixes testcontainers#1383
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
HofmeisterAn
changed the title
CreatedTime for UntilMessageIsLogged wait strategy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This pull request retrieves logs since
CreatedTimefor theUntilMessageIsLoggedwait strategy to ensure that logs from the previous run are ignored and only logs from the current run are processed.Why is it important?
This is required for reused containers since old logs (from previous runs) are still available.
Related issues
Fixes #1383
How to test this PR
See sample program in #1383